On Wed, Dec 8, 2021 at 11:32 AM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > > On 12/8/21 5:44 AM, Rob Herring wrote: > > On Tue, 07 Dec 2021 20:04:32 -0800, Florian Fainelli wrote: > >> Conver the iProc PCIe controller Device Tree binding to YAML now that > >> all DTS in arch/arm and arch/arm64 have been fixed to be compliant. > >> > >> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > >> --- > >> .../bindings/pci/brcm,iproc-pcie.txt | 133 ------------- > >> .../bindings/pci/brcm,iproc-pcie.yaml | 176 ++++++++++++++++++ > >> 2 files changed, 176 insertions(+), 133 deletions(-) > >> delete mode 100644 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt > >> create mode 100644 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml > >> > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/patch/1565076 > > > > > > pcie@18012000: msi-controller: 'oneOf' conditional failed, one must be fixed: > > arch/arm/boot/dts/bcm53340-ubnt-unifi-switch8.dt.yaml > > arch/arm/boot/dts/bcm911360_entphn.dt.yaml > > arch/arm/boot/dts/bcm911360k.dt.yaml > > arch/arm/boot/dts/bcm958300k.dt.yaml > > arch/arm/boot/dts/bcm958305k.dt.yaml > > arch/arm/boot/dts/bcm958522er.dt.yaml > > arch/arm/boot/dts/bcm958525er.dt.yaml > > arch/arm/boot/dts/bcm958525xmc.dt.yaml > > arch/arm/boot/dts/bcm958622hr.dt.yaml > > arch/arm/boot/dts/bcm958623hr.dt.yaml > > arch/arm/boot/dts/bcm958625hr.dt.yaml > > arch/arm/boot/dts/bcm958625k.dt.yaml > > arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dt.yaml > > arch/arm/boot/dts/bcm958625-meraki-mx64.dt.yaml > > arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dt.yaml > > arch/arm/boot/dts/bcm958625-meraki-mx64w.dt.yaml > > arch/arm/boot/dts/bcm958625-meraki-mx65.dt.yaml > > arch/arm/boot/dts/bcm958625-meraki-mx65w.dt.yaml > > arch/arm/boot/dts/bcm988312hr.dt.yaml > > Those would mean that the binding patch was applied without the DTS > patches earlier in the series? Right. I generally don't look at dts patches, but I did look at these and don't see how this one is fixed (nor caused): pcie@18012000: Unevaluated properties are not allowed ('linux,pci-domain', 'bus-range', '#address-cells', '#size-cells', 'device_type' were unexpected) arch/arm/boot/dts/bcm911360_entphn.dt.yaml arch/arm/boot/dts/bcm911360k.dt.yaml arch/arm/boot/dts/bcm958300k.dt.yaml arch/arm/boot/dts/bcm958305k.dt.yaml