Re: [PATCH v3 12/18] iommu: Add iommu_at[de]tach_device_shared() for multi-device groups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 12/18] iommu: Add iommu_at[de]tach_device_shared() for multi-device groups
From: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
Date: Tue, 7 Dec 2021 10:33:21 +0800
Cc: baolu.lu@xxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Ashok Raj <ashok.raj@xxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, rafael@xxxxxxxxxx, Diana Craciun <diana.craciun@xxxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Eric Auger <eric.auger@xxxxxxxxxx>, Liu Yi L <yi.l.liu@xxxxxxxxx>, Jacob jun Pan <jacob.jun.pan@xxxxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, Stuart Yoder <stuyoder@xxxxxxxxx>, Laurentiu Tudor <laurentiu.tudor@xxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Jonathan Hunter <jonathanh@xxxxxxxxxx>, Li Yang <leoyang.li@xxxxxxx>, Dmitry Osipenko <digetx@xxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Ya4hk91RWnPWB4nE@infradead.org>
References: <20211206015903.88687-1-baolu.lu@linux.intel.com> <20211206015903.88687-13-baolu.lu@linux.intel.com> <Ya4hk91RWnPWB4nE@infradead.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 12/6/21 10:43 PM, Christoph Hellwig wrote:

The new helpers really could use a kerneldoc comment.
Also no need for the refcount_t with it's atomic operations for
attach_cnt either.


Yes. Agreed.

Best regards,
baolu

References:
- [PATCH v3 00/18] Fix BUG_ON in vfio_iommu_group_notifier()
  - From: Lu Baolu
- [PATCH v3 12/18] iommu: Add iommu_at[de]tach_device_shared() for multi-device groups
  - From: Lu Baolu
- Re: [PATCH v3 12/18] iommu: Add iommu_at[de]tach_device_shared() for multi-device groups
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH v3 01/18] iommu: Add device dma ownership set/release interfaces
Next by Date: Re: [PATCH v3 18/18] drm/tegra: Use the iommu dma_owner mechanism
Previous by thread: Re: [PATCH v3 12/18] iommu: Add iommu_at[de]tach_device_shared() for multi-device groups
Next by thread: [PATCH v3 14/18] vfio: Remove use of vfio_group_viable()
Index(es):
- Date
- Thread

[Index of Archives] [DMA Engine] [Linux Coverity] [Linux USB] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Greybus]