On Mon, 15 Nov 2021 13:20:00 +0200, Andy Shevchenko wrote: > Use BIT() as __GENMASK() is for internal use only. The rationale > of switching to BIT() is to provide better generated code. The > GENMASK() against non-constant numbers may produce an ugly assembler > code. On contrary the BIT() is simply converted to corresponding shift > operation. > > Note, it's the only user of __GENMASK() in the kernel outside of its own realm. > > [...] Applied to pci/brcmstb, thanks! [1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for internal use only https://git.kernel.org/lpieralisi/pci/c/6ec6eb949d Thanks, Lorenzo