On Fri, 19 Nov 2021 16:02:36 -0800 Ben Widawsky <ben.widawsky@xxxxxxxxx> wrote: > Many CXL drivers simply want to register and unregister themselves. > module_driver already supported this. A simple wrapper around that > reduces a decent amount of boilerplate in upcoming patches. > > Suggested-by: Dan Williams <dan.j.williams@xxxxxxxxx> > Signed-off-by: Ben Widawsky <ben.widawsky@xxxxxxxxx> Makes sense although, when compared with using the module_driver macro directly it's a fairly minor reduction in boilerplate. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > --- > drivers/cxl/cxl.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h > index 7150a9694f66..d39d45f4a770 100644 > --- a/drivers/cxl/cxl.h > +++ b/drivers/cxl/cxl.h > @@ -308,6 +308,9 @@ int __cxl_driver_register(struct cxl_driver *cxl_drv, struct module *owner, > #define cxl_driver_register(x) __cxl_driver_register(x, THIS_MODULE, KBUILD_MODNAME) > void cxl_driver_unregister(struct cxl_driver *cxl_drv); > > +#define module_cxl_driver(__cxl_driver) \ > + module_driver(__cxl_driver, cxl_driver_register, cxl_driver_unregister) > + > #define CXL_DEVICE_NVDIMM_BRIDGE 1 > #define CXL_DEVICE_NVDIMM 2 >
