Hi Qi,
Thank you for looking into things I've mentioned!
[...]
> > Would the above "bdf" be the PCI addressing schema? If so, then we could
> > capitalise the acronym to keep it consistent with how it's often referred
> > to in the PCI world.
> >
[...]
> got it, will change it to Bdf to keep the consistent, thanks.
Just to make sure - the "Bus, Device, Function" in the world of PCI usually
uses the acronym of "BDF", all uppercase letters.
> > [...]
> > > +static int __init hisi_pcie_module_init(void)
> > > +{
> > > + int ret;
> > > +
> > > + ret = cpuhp_setup_state_multi(CPUHP_AP_PERF_ARM_HISI_PCIE_PMU_ONLINE,
> > > + "AP_PERF_ARM_HISI_PCIE_PMU_ONLINE",
> > > + hisi_pcie_pmu_online_cpu,
> > > + hisi_pcie_pmu_offline_cpu);
> > > + if (ret) {
> > > + pr_err("Failed to setup PCIe PMU hotplug, ret = %d.\n", ret);
> > > + return ret;
> > > + }
> >
> > The above error message could be made to be a little more aligned in terms
> > of format with the other messages, thus it would be as follows:
> >
> > pr_err("Failed to setup PCIe PMU hotplug: %d.\n", ret);
> >
> > Interestingly, there would be then no need to add the final dot (period) at
> > the end here, and that would be true everywhere else.
> >
>
> thanks for your reminder , I'll fix that printout message to keep align.
Thank you!
Don't forget to drop the trailing dot after the error code (it makes it
easier to read or even parse in a script, etc.).
Again, thank you so much for working on this driver! An amazing work!
Krzysztof
