On Sun, Nov 14, 2021 at 04:31:43AM +0100, Krzysztof Wilczyński wrote: > Hi Andy, > > Nice find! There might one more driver that leverages the vendor-specific > capabilities that seems to be also open coding pci_find_vsec_capability(), > as per: > ... > Do you think that it would be worthwhile to also update this other driver > to use pci_find_vsec_capability() at the same time? I might be nice to rid > of the other open coded implementation too. You mean https://lore.kernel.org/linux-fpga/20211109154127.18455-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u? It seems a bit hard to explain HW people how the Linux kernel development process is working. (Yes, shame on me that I haven't compiled that one) ... > > Currently the set_pcie_thunderbolt() opens code pci_find_vsec_capability(). > > I would write it as "open codes" in the above. Hmm... Is anybody among us a native speaker (me — no)? :-) But if you think it's better like this I'll definitely change. (I admit I'm lost in a morphological analysis of the above two words) ... > Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx> Thank you! -- With Best Regards, Andy Shevchenko
