Fix following coccicheck warning: ./drivers/pci/controller/dwc/pcie-kirin.c:414:2-34: WARNING: Function for_each_available_child_of_node should have of_node_put() before return. Early exits from for_each_available_child_of_node should decrement the node reference counter. Replace return by goto here. Signed-off-by: Wan Jiabing <wanjiabing@xxxxxxxx> --- drivers/pci/controller/dwc/pcie-kirin.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c index 06017e826832..23a2c076ce53 100644 --- a/drivers/pci/controller/dwc/pcie-kirin.c +++ b/drivers/pci/controller/dwc/pcie-kirin.c @@ -422,7 +422,8 @@ static int kirin_pcie_parse_port(struct kirin_pcie *pcie, pcie->num_slots++; if (pcie->num_slots > MAX_PCI_SLOTS) { dev_err(dev, "Too many PCI slots!\n"); - return -EINVAL; + ret = -EINVAL; + goto put_node; } ret = of_pci_get_devfn(child); -- 2.20.1