Hi Bjorn, On Thu, Oct 21, 2021 at 5:52 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > On Wed, Oct 20, 2021 at 03:23:45PM +0100, Lorenzo Pieralisi wrote: > > On Wed, 22 Sep 2021 07:00:32 +0200, Sergio Paracuellos wrote: > > > MediaTek MT7621 PCIe subsys supports single Root complex (RC) > > > with 3 Root Ports. Each Root Ports supports a Gen1 1-lane Link. > > > Topology is as follows: > > > > > > > > > MT7621 PCIe HOST Topology > > > > > > [...] > > > > Applied to pci/mt7621, thanks! > > > > [1/3] dt-bindings: mt7621-pci: PCIe binding documentation for MT7621 SoCs > > https://git.kernel.org/lpieralisi/pci/c/e5bc5605e7 > > [2/3] PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver > > https://git.kernel.org/lpieralisi/pci/c/5797a2b2bc > > [3/3] MAINTAINERS: add myself as maintainer of the MT7621 PCI controller driver > > https://git.kernel.org/lpieralisi/pci/c/eb1d7d438c > > Since this is a PCIe (not conventional PCI) controller, I vote for > renaming these from: > > PCI_MT7621 > Documentation/devicetree/bindings/pci/mediatek,mt7621-pci.yaml > drivers/pci/controller/pci-mt7621.c > > to: > > PCIE_MT7621 > Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml > drivers/pci/controller/pcie-mt7621.c > > We have a mix of these, with many of the early PCIe drivers being > named "pci", but I think that was my mistake and there's no reason to > continue it. I see. > > I can do this locally unless somebody objects. I have no problem at all. Only one question. Do you mean to change compatible string also, or only the name of the file? Let me know if I have to do anything. Thanks, Sergio Paracuellos