Em Mon, 18 Oct 2021 11:21:27 +0100 Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> escreveu: > On Mon, Oct 18, 2021 at 08:07:34AM +0100, Mauro Carvalho Chehab wrote: > > This driver currently doesn't call dw_pcie_host_deinit() > > at the .remove() callback. This can cause an OOPS if the driver > > is unbound. > > This looks like a fix, it has to be marked as such. Well, without patch 10/10, the .remove() ops won't be called, so, it is not really a fix, but I can surely add a c/c stable@xxxxxxxxxxxxxxx and add a Fixes: tag here. > > > While here, add a poweroff function, in order to abstract > > between the internal and external PHY logic. > > > > Acked-by: Xiaowei Song <songxiaowei@xxxxxxxxxxxxx> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> > > --- > > > > See [PATCH v13 00/10] at: https://lore.kernel.org/all/cover.1634539769.git.mchehab+huawei@xxxxxxxxxx/ > > > > drivers/pci/controller/dwc/pcie-kirin.c | 30 ++++++++++++++++--------- > > 1 file changed, 20 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c > > index b17a194cf78d..ffc63d12f8ed 100644 > > --- a/drivers/pci/controller/dwc/pcie-kirin.c > > +++ b/drivers/pci/controller/dwc/pcie-kirin.c > > @@ -680,6 +680,23 @@ static const struct dw_pcie_host_ops kirin_pcie_host_ops = { > > .host_init = kirin_pcie_host_init, > > }; > > > > +static int kirin_pcie_power_off(struct kirin_pcie *kirin_pcie) > > +{ > > + int i; > > + > > + if (kirin_pcie->type == PCIE_KIRIN_INTERNAL_PHY) > > + return hi3660_pcie_phy_power_off(kirin_pcie); > > + > > + for (i = 0; i < kirin_pcie->n_gpio_clkreq; i++) { > > + gpio_direction_output(kirin_pcie->gpio_id_clkreq[i], 1); > > + } > > It looks like you are adding functionality here (ie gpio), not > just wrapping common code in a function. It is just reverting the power on logic there. > > Also, remove the braces, they aren't needed. Yeah, I forgot to drop it, when I dropped a tem code that had some dev_dbg() on it. I'll drop on v14. Regards, Mauro
