Re: [PATCH][next] PCI: apple: Remove redundant initialization of pointer port_pdev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13/10/2021 14:41, Lorenzo Pieralisi wrote:
On Tue, Oct 12, 2021 at 02:32:35PM +0100, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

The pointer port_pdev is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
  drivers/pci/controller/pcie-apple.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Squashed into the commit it is fixing.


Thanks. Much appreciated.

Thanks !
Lorenzo

diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
index b4db7a065553..19fd2d38aaab 100644
--- a/drivers/pci/controller/pcie-apple.c
+++ b/drivers/pci/controller/pcie-apple.c
@@ -634,7 +634,7 @@ static struct apple_pcie_port *apple_pcie_get_port(struct pci_dev *pdev)
  {
  	struct pci_config_window *cfg = pdev->sysdata;
  	struct apple_pcie *pcie = cfg->priv;
-	struct pci_dev *port_pdev = pdev;
+	struct pci_dev *port_pdev;
  	struct apple_pcie_port *port;
/* Find the root port this device is on */
--
2.32.0





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux