Hi Bjorn, > > Internally, printk() et al already correctly handles the standard > > integer promotions, so there is no need to explicitly "%h" modifier as > > part of a format string such as "%hx". > > > > Thus, drop the "%h" modifier as it's completely unnecessary (N.B. this > > wouldn't be true for the sscanf() function family), and match preferred > > coding style. > > > > Related: > > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary > > commit 70eb2275ff8e ("checkpatch: add warning for unnecessary use of %h[xudi] and %hh[xudi]") > > https://lore.kernel.org/lkml/CAHk-=wgoxnmsj8GEVFJSvTwdnWm8wVJthefNk2n6+4TC=20e0Q@xxxxxxxxxxxxxx/ > > > > No change to functionality intended. > > Applied 1/3 and 3/3 to pci/misc for v5.16, thanks! > > For 2/3, I think we might want to convert the VF ID to be unsigned > consistently. Will do! I am going to send a separate patch for it. Krzysztof