On Mon, Oct 11, 2021 at 08:15:53PM +0200, Pali Rohár wrote: > On Wednesday 06 October 2021 00:45:31 Marek Behún wrote: > > PS: Btw, looking at the code, why do we use these PCIBIOS_* macros? And > > then sometimes convert them to error codes with pcibios_err_to_errno()? > > Is this some legacy thing? Should this be converted to errno? > > Hello! I would like to remind this Marek's PS. Do you know why config > read and write functions return these PCIBIOS_* macros and not standard > linux errno codes? I don't know. The PCIBIOS_SUCCESSFUL..PCIBIOS_BUFFER_TOO_SMALL codes are actually still in the latest PCI Firmware Spec, r3.3, of 1/20/2021, sec 2.9, but are clearly x86-specific. I think it would be nicer if their usage were confined to arch/x86, but they've leaked out somewhat.
