Re: [PATCH 1/5] thermal: tegra-bpmp: Handle errors in BPMP response

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 15, 2021 at 11:55:13AM +0300, Mikko Perttunen wrote:
> The return value from tegra_bpmp_transfer indicates the success or
> failure of the IPC transaction with BPMP. If the transaction
> succeeded, we also need to check the actual command's result code.
> Add code to do this.
> 
> Signed-off-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
> ---
>  drivers/thermal/tegra/tegra-bpmp-thermal.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)

Perhaps this should be moved into tegra_bpmp_transfer() or some new
helper to make sure we can keep this consistent across all callers.

For instance, I'm not sure -EINVAL is the right (or best) error code in
all the cases. Either way, seems fine in this case and this is certainly
an improvement, so:

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux