On Wed, Oct 06, 2021 at 02:26:41PM +0300, Heikki Krogerus wrote: > In quirk_huawei_pcie_sva(), use device_create_managed_software_node() > instead of device_add_properties() to set the "dma-can-stall" > property. > > This is the last user of device_add_properties() that relied on > device_del() to take care of also calling device_remove_properties(). > After this change we can finally get rid of that > device_remove_properties() call in device_del(). > > After that device_remove_properties() call has been removed from > device_del(), the software nodes that hold the additional device > properties become reusable and shareable as there is no longer a > default assumption that those nodes are lifetime bound the first > device they are associated with. This does not help me determine whether this patch is safe. device_create_managed_software_node() sets swnode->managed = true, but device_add_properties() did not. I still don't know what the effect of that is. > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Acked-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx> > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > --- > drivers/pci/quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index b6b4c803bdc94..fe5eedba47908 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -1850,7 +1850,7 @@ static void quirk_huawei_pcie_sva(struct pci_dev *pdev) > * can set it directly. > */ > if (!pdev->dev.of_node && > - device_add_properties(&pdev->dev, properties)) > + device_create_managed_software_node(&pdev->dev, properties, NULL)) > pci_warn(pdev, "could not add stall property"); > } > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_HUAWEI, 0xa250, quirk_huawei_pcie_sva); > -- > 2.33.0 >
