On Wed, 6 Oct 2021 10:13:38 +0100
Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> wrote:
> [CC Sasha for stable kernel rules]
>
> On Tue, Oct 05, 2021 at 08:09:46PM +0200, Marek Behún wrote:
> > From: Pali Rohár <pali@xxxxxxxxxx>
> >
> > There are lot of undocumented interrupt bits. Fix all *_ALL_MASK macros to
> > define all interrupt bits, so that driver can properly mask all interrupts,
> > including those which are undocumented.
> >
> > Fixes: 8c39d710363c ("PCI: aardvark: Add Aardvark PCI host controller driver")
> > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> > Reviewed-by: Marek Behún <kabel@xxxxxxxxxx>
> > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
>
> I don't think this is a fix and I don't think it should be sent
> to stable kernels in _preparation_ for other fixes to come (that
> may never land in mainline).
This patch is a fix because it fixes masking interrupts, which may
prevent spurious interrupts - we don't want interrupts which kernel
didn't request for.
I agree that the commit message should probably mention this, though...
:(
Marek
