Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on groeck-staging/hwmon-next] [also build test ERROR on helgaas-pci/next linux/master linus/master v5.15-rc3 next-20210921] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/watchdog-wdt_pci-Correct-the-PCI-ID-vendor-name/20211005-231553 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: x86_64-randconfig-a015-20211004 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/2ee39529d02438ed2b87a6a1cc2040b7d96563e1 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/watchdog-wdt_pci-Correct-the-PCI-ID-vendor-name/20211005-231553 git checkout 2ee39529d02438ed2b87a6a1cc2040b7d96563e1 # save the attached .config to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from drivers/tty/serial/8250/8250_exar.c:14: >> include/linux/pci.h:1000:12: error: 'PCI_VENDOR_ID_ACCESSIO' undeclared here (not in a function); did you mean 'PCI_VENDOR_ID_ACCESIO'? 1000 | .vendor = PCI_VENDOR_ID_##vend, .device = PCI_DEVICE_ID_##vend##_##dev, \ | ^~~~~~~~~~~~~~ drivers/tty/serial/8250/8250_exar.c:813:40: note: in expansion of macro 'PCI_DEVICE_DATA' 813 | #define EXAR_DEVICE(vend, devid, bd) { PCI_DEVICE_DATA(vend, devid, &bd) } | ^~~~~~~~~~~~~~~ drivers/tty/serial/8250/8250_exar.c:825:2: note: in expansion of macro 'EXAR_DEVICE' 825 | EXAR_DEVICE(ACCESSIO, COM_2S, acces_com_2x), | ^~~~~~~~~~~ vim +1000 include/linux/pci.h ^1da177e4c3f41 Linus Torvalds 2005-04-16 904 ^1da177e4c3f41 Linus Torvalds 2005-04-16 905 /** 0aa0f5d1084ca1 Bjorn Helgaas 2017-12-02 906 * PCI_DEVICE - macro used to describe a specific PCI device ^1da177e4c3f41 Linus Torvalds 2005-04-16 907 * @vend: the 16 bit PCI Vendor ID ^1da177e4c3f41 Linus Torvalds 2005-04-16 908 * @dev: the 16 bit PCI Device ID ^1da177e4c3f41 Linus Torvalds 2005-04-16 909 * ^1da177e4c3f41 Linus Torvalds 2005-04-16 910 * This macro is used to create a struct pci_device_id that matches a ^1da177e4c3f41 Linus Torvalds 2005-04-16 911 * specific device. The subvendor and subdevice fields will be set to ^1da177e4c3f41 Linus Torvalds 2005-04-16 912 * PCI_ANY_ID. ^1da177e4c3f41 Linus Torvalds 2005-04-16 913 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 914 #define PCI_DEVICE(vend,dev) \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 915 .vendor = (vend), .device = (dev), \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 916 .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID ^1da177e4c3f41 Linus Torvalds 2005-04-16 917 343b7258687ecf Max Gurtovoy 2021-08-26 918 /** 343b7258687ecf Max Gurtovoy 2021-08-26 919 * PCI_DEVICE_DRIVER_OVERRIDE - macro used to describe a PCI device with 343b7258687ecf Max Gurtovoy 2021-08-26 920 * override_only flags. 343b7258687ecf Max Gurtovoy 2021-08-26 921 * @vend: the 16 bit PCI Vendor ID 343b7258687ecf Max Gurtovoy 2021-08-26 922 * @dev: the 16 bit PCI Device ID 343b7258687ecf Max Gurtovoy 2021-08-26 923 * @driver_override: the 32 bit PCI Device override_only 343b7258687ecf Max Gurtovoy 2021-08-26 924 * 343b7258687ecf Max Gurtovoy 2021-08-26 925 * This macro is used to create a struct pci_device_id that matches only a 343b7258687ecf Max Gurtovoy 2021-08-26 926 * driver_override device. The subvendor and subdevice fields will be set to 343b7258687ecf Max Gurtovoy 2021-08-26 927 * PCI_ANY_ID. 343b7258687ecf Max Gurtovoy 2021-08-26 928 */ 343b7258687ecf Max Gurtovoy 2021-08-26 929 #define PCI_DEVICE_DRIVER_OVERRIDE(vend, dev, driver_override) \ 343b7258687ecf Max Gurtovoy 2021-08-26 930 .vendor = (vend), .device = (dev), .subvendor = PCI_ANY_ID, \ 343b7258687ecf Max Gurtovoy 2021-08-26 931 .subdevice = PCI_ANY_ID, .override_only = (driver_override) 343b7258687ecf Max Gurtovoy 2021-08-26 932 cc6711b0bf36de Max Gurtovoy 2021-08-26 933 /** cc6711b0bf36de Max Gurtovoy 2021-08-26 934 * PCI_DRIVER_OVERRIDE_DEVICE_VFIO - macro used to describe a VFIO cc6711b0bf36de Max Gurtovoy 2021-08-26 935 * "driver_override" PCI device. cc6711b0bf36de Max Gurtovoy 2021-08-26 936 * @vend: the 16 bit PCI Vendor ID cc6711b0bf36de Max Gurtovoy 2021-08-26 937 * @dev: the 16 bit PCI Device ID cc6711b0bf36de Max Gurtovoy 2021-08-26 938 * cc6711b0bf36de Max Gurtovoy 2021-08-26 939 * This macro is used to create a struct pci_device_id that matches a cc6711b0bf36de Max Gurtovoy 2021-08-26 940 * specific device. The subvendor and subdevice fields will be set to cc6711b0bf36de Max Gurtovoy 2021-08-26 941 * PCI_ANY_ID and the driver_override will be set to cc6711b0bf36de Max Gurtovoy 2021-08-26 942 * PCI_ID_F_VFIO_DRIVER_OVERRIDE. cc6711b0bf36de Max Gurtovoy 2021-08-26 943 */ cc6711b0bf36de Max Gurtovoy 2021-08-26 944 #define PCI_DRIVER_OVERRIDE_DEVICE_VFIO(vend, dev) \ cc6711b0bf36de Max Gurtovoy 2021-08-26 945 PCI_DEVICE_DRIVER_OVERRIDE(vend, dev, PCI_ID_F_VFIO_DRIVER_OVERRIDE) cc6711b0bf36de Max Gurtovoy 2021-08-26 946 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 947 /** 0aa0f5d1084ca1 Bjorn Helgaas 2017-12-02 948 * PCI_DEVICE_SUB - macro used to describe a specific PCI device with subsystem 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 949 * @vend: the 16 bit PCI Vendor ID 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 950 * @dev: the 16 bit PCI Device ID 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 951 * @subvend: the 16 bit PCI Subvendor ID 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 952 * @subdev: the 16 bit PCI Subdevice ID 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 953 * 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 954 * This macro is used to create a struct pci_device_id that matches a 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 955 * specific device with subsystem information. 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 956 */ 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 957 #define PCI_DEVICE_SUB(vend, dev, subvend, subdev) \ 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 958 .vendor = (vend), .device = (dev), \ 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 959 .subvendor = (subvend), .subdevice = (subdev) 3d567e0e291c4f Nithin Nayak Sujir 2012-11-14 960 ^1da177e4c3f41 Linus Torvalds 2005-04-16 961 /** 0aa0f5d1084ca1 Bjorn Helgaas 2017-12-02 962 * PCI_DEVICE_CLASS - macro used to describe a specific PCI device class ^1da177e4c3f41 Linus Torvalds 2005-04-16 963 * @dev_class: the class, subclass, prog-if triple for this device ^1da177e4c3f41 Linus Torvalds 2005-04-16 964 * @dev_class_mask: the class mask for this device ^1da177e4c3f41 Linus Torvalds 2005-04-16 965 * ^1da177e4c3f41 Linus Torvalds 2005-04-16 966 * This macro is used to create a struct pci_device_id that matches a ^1da177e4c3f41 Linus Torvalds 2005-04-16 967 * specific PCI class. The vendor, device, subvendor, and subdevice ^1da177e4c3f41 Linus Torvalds 2005-04-16 968 * fields will be set to PCI_ANY_ID. ^1da177e4c3f41 Linus Torvalds 2005-04-16 969 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 970 #define PCI_DEVICE_CLASS(dev_class,dev_class_mask) \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 971 .class = (dev_class), .class_mask = (dev_class_mask), \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 972 .vendor = PCI_ANY_ID, .device = PCI_ANY_ID, \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 973 .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID ^1da177e4c3f41 Linus Torvalds 2005-04-16 974 1597cacbe39802 Alan Cox 2006-12-04 975 /** 0aa0f5d1084ca1 Bjorn Helgaas 2017-12-02 976 * PCI_VDEVICE - macro used to describe a specific PCI device in short form c1309040967e20 Mark Rustad 2014-03-31 977 * @vend: the vendor name c1309040967e20 Mark Rustad 2014-03-31 978 * @dev: the 16 bit PCI Device ID 1597cacbe39802 Alan Cox 2006-12-04 979 * 1597cacbe39802 Alan Cox 2006-12-04 980 * This macro is used to create a struct pci_device_id that matches a 1597cacbe39802 Alan Cox 2006-12-04 981 * specific PCI device. The subvendor, and subdevice fields will be set 1597cacbe39802 Alan Cox 2006-12-04 982 * to PCI_ANY_ID. The macro allows the next field to follow as the device 1597cacbe39802 Alan Cox 2006-12-04 983 * private data. 1597cacbe39802 Alan Cox 2006-12-04 984 */ c1309040967e20 Mark Rustad 2014-03-31 985 #define PCI_VDEVICE(vend, dev) \ c1309040967e20 Mark Rustad 2014-03-31 986 .vendor = PCI_VENDOR_ID_##vend, .device = (dev), \ c1309040967e20 Mark Rustad 2014-03-31 987 .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID, 0, 0 1597cacbe39802 Alan Cox 2006-12-04 988 b72ae8cac0caff Andy Shevchenko 2018-07-29 989 /** b72ae8cac0caff Andy Shevchenko 2018-07-29 990 * PCI_DEVICE_DATA - macro used to describe a specific PCI device in very short form b72ae8cac0caff Andy Shevchenko 2018-07-29 991 * @vend: the vendor name (without PCI_VENDOR_ID_ prefix) b72ae8cac0caff Andy Shevchenko 2018-07-29 992 * @dev: the device name (without PCI_DEVICE_ID_<vend>_ prefix) b72ae8cac0caff Andy Shevchenko 2018-07-29 993 * @data: the driver data to be filled b72ae8cac0caff Andy Shevchenko 2018-07-29 994 * b72ae8cac0caff Andy Shevchenko 2018-07-29 995 * This macro is used to create a struct pci_device_id that matches a b72ae8cac0caff Andy Shevchenko 2018-07-29 996 * specific PCI device. The subvendor, and subdevice fields will be set b72ae8cac0caff Andy Shevchenko 2018-07-29 997 * to PCI_ANY_ID. b72ae8cac0caff Andy Shevchenko 2018-07-29 998 */ b72ae8cac0caff Andy Shevchenko 2018-07-29 999 #define PCI_DEVICE_DATA(vend, dev, data) \ b72ae8cac0caff Andy Shevchenko 2018-07-29 @1000 .vendor = PCI_VENDOR_ID_##vend, .device = PCI_DEVICE_ID_##vend##_##dev, \ b72ae8cac0caff Andy Shevchenko 2018-07-29 1001 .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID, 0, 0, \ b72ae8cac0caff Andy Shevchenko 2018-07-29 1002 .driver_data = (kernel_ulong_t)(data) b72ae8cac0caff Andy Shevchenko 2018-07-29 1003 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
