Hi Max, [...] > > #ifdef CONFIG_NUMA > > - mask = (dev_to_node(dev) == -1) ? cpu_online_mask : > > - cpumask_of_node(dev_to_node(dev)); > > + mask = (dev_to_node(dev) == NUMA_NO_NODE) ? cpu_online_mask : > > + cpumask_of_node(dev_to_node(dev)); > > Oh this somewhat awkward indentation we have with this ternary now, > and so I wonder if either: > > mask = (dev_to_node(dev) == NUMA_NO_NODE) ? > cpu_online_mask : cpumask_of_node(dev_to_node(dev)); > > Or, perhaps (yes, a few more lines): > > if (dev_to_node(dev) == NUMA_NO_NODE) > mask = cpu_online_mask; > else > mask = cpumask_of_node(node); Doh! I should be cpumask_of_node(dev_to_node(dev)) in the above, of course. Apologies! Albeit, v3 you sent looks great! Thank you! Krzysztof
