Re: [PATCH] PCI: rcar: pcie-rcar-host: Remove unneeded includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjorn,

On Sat, Oct 2, 2021 at 9:01 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> On Sat, Oct 02, 2021 at 08:22:13PM +0200, Geert Uytterhoeven wrote:
> > On Sat, Oct 2, 2021 at 6:00 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> > > Seems overkill to mention "rcar" and "pci" twice in the subject.  We
> > > have so far not distinguished pcie-rcar-host.c and pcie-rcar-ep.c in
> > > subject lines.
> > >
> > > If we want to start doing that consistently, maybe we could use "PCI:
> > > rcar-host:" and "PCI: rcar-ep:" as we have done for cadence-ep and
> > > designware-ep.
> >
> > I know.  But this is for PCIe, and there's also pci-rcar-gen2 for traditional
> > PCI.
>
> We do have a precedent of "rcar-gen2" for that driver:

Feel free to change the prefix while applying.
Or ask for a resend, and risk me not changing it to your liking again ;-)

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux