On Tue, Sep 28, 2021 at 08:54:45AM +0100, Lee Jones wrote: > On Mon, 27 Sep 2021, David E. Box wrote: > > > On Mon, 2021-09-27 at 19:36 +0200, Greg KH wrote: > > > On Wed, Sep 22, 2021 at 02:30:04PM -0700, David E. Box wrote: > > > > Intel Platform Monitoring Technology (PMT) support is indicated by presence > > > > of an Intel defined PCIe DVSEC structure with a PMT ID. However DVSEC > > > > structures may also be used by Intel to indicate support for other > > > > capabilities unrelated to PMT. OOBMSM is a device that can have both PMT > > > > and non-PMT capabilities. In order to support these capabilities it is > > > > necessary to modify the intel_pmt driver to handle the creation of platform > > > > devices more generically. > > > > > > I said this on your other driver submission, but why are you turning a > > > PCIe device into a set of platform devices and craming it into the MFD > > > subsystem? > > > > > > PCIe devices are NOT platform devices. > > > > But they *are* used to create platform devices when the PCIe device is multi-functional, which is > > what intel_pmt is. > > > > > > > > Why not use the auxiliary bus for this thing if you have individual > > > drivers that need to "bind" to the different attributes that this single > > > PCIe device is exporting. > > > > It wasn't clear in the beginning how this would evolve. MFD made sense for the PMT (platform > > monitoring technology) driver. PMT has 3 related but individually enumerable devices on the same IP, > > like lpss. But the same IP is now being used for other features too like SDSi. We could work on > > converting this to the auxiliary bus and then covert the cell drivers. > > I see this as subsequent work. It should not affect this submission. > > FWIW, I still plan to review this set for inclusion into MFD. That's fine, but as the add-on submission that builds on top of this is a broken mess (which is what caused me to have to review this series), I can't recommend that be taken yet as it needs work to prevent systems from doing bad things. thanks, greg k-h
