Hi Bjorn, [...] > > Check if the "CAP_SYS_ADMIN" capability flag is set before parsing user > > input as it makes more sense to first check whether the current user > > actually has the right permissions before accepting any input from such > > user. > > > > This will also make order in which enable_store() and msi_bus_store() > > perform the "CAP_SYS_ADMIN" capability check consistent with other > > PCI-related sysfs objects that first verify whether user has this > > capability set. > > I like this one. Can you rebase it to skip patch 1/4 (unless you > convince me that 1/4 is safe)? I will remove it, as per: https://lore.kernel.org/linux-pci/20210915011204.GA1444093@rocinante/T/#t Thank you! Krzysztof
