On Tue, Sep 14, 2021 at 08:21:46AM +0200, Heiner Kallweit wrote: > On 14.09.2021 01:46, Bjorn Helgaas wrote: > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATTANSIC, PCI_ANY_ID, quirk_blacklist_vpd); > > /* > > Leaving the quirks in FIXUP_HEADER stage would have the advantage that for > blacklisted devices the vpd sysfs attribute isn't visibale. The needed > changes to the patch are minimal. What do you have in mind? The only thing I can think of would be to add a "pci_dev.no_vpd" bit. "vpd.cap == 0" means the device has no VPD, and "vpd.len == 0" means we haven't determined the size yet. All devices start off with vpd.cap == 0 and vpd.len == 0, so a FIXUP_HEADER quirk would have to set a sentinel value or some other bit. Bjorn
