Make your subject line follow the previous convention. Figure out if this is a "probable" or a real double put. If it's a real double put, we should fix it. If it's only "probable," that means we don't understand the problem yet. On Tue, Sep 07, 2021 at 08:59:46AM +0000, Xu Wang wrote: > Device node iterators put the previous value of the index variable, > so an explicit put causes a double put. > > Signed-off-by: Xu Wang <vulab@xxxxxxxxxxx> > --- > drivers/pci/hotplug/pnv_php.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c > index 04565162a449..ed4d1a2c3f22 100644 > --- a/drivers/pci/hotplug/pnv_php.c > +++ b/drivers/pci/hotplug/pnv_php.c > @@ -158,7 +158,6 @@ static void pnv_php_detach_device_nodes(struct device_node *parent) > for_each_child_of_node(parent, dn) { > pnv_php_detach_device_nodes(dn); > > - of_node_put(dn); > of_detach_node(dn); > } > } > -- > 2.17.1 >