On Fri, Aug 13, 2021 at 03:32:50PM +0100, Mark Brown wrote: > On Fri, Aug 13, 2021 at 03:01:10PM +0100, Robin Murphy wrote: > > > Indeed I've thought before that it would be nice if regulators worked like > > GPIOs, where the absence of an optional one does give you NULL, and most of > > the API is also NULL-safe. Probably a pretty big job though... > > It also encourages *really* bad practice with error handling I'm not necessarily 100% positive what you mean by this. I think you mean you don't like when people pass invalid pointers to free functions? But making regulator code NULL-safe wouldn't affect error handling because NULL wouldn't be an error. p = get_optional(); if (IS_ERR(p)) return PTR_ERR(p); enable(p); ... disable(p); It all works nicely. regards, dan carpenter