On Thu, Jul 29 2021 at 23:40, Krzysztof Wilczyński wrote: > At the moment, the function pci_numachip_init() is defined in the > numachip.c file. Since this function has users outside of this file, > add missing foward declaration to the pci_x86.h file. > > This resolves the following sparse and compile time warning: > > arch/x86/pci/numachip.c:108:12: warning: no previous prototype for function 'pci_numachip_init' [-Wmissing-prototypes] > arch/x86/pci/numachip.c:108:12: warning: symbol 'pci_numachip_init' > was not declared. Should it be static? No. arch/x86/pci/numachip.c simply lacks #include <asm/numachip/numachip.h> Thanks, tglx