On 06/14/2011 04:54 PM, Bjorn Helgaas wrote:
> On Tue, Jun 14, 2011 at 4:45 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> On Tue, Jun 14, 2011 at 12:04 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>>> I don't think there's enough value in the fact of a bridge window
>>> being disabled to justify cluttering the dmesg log with it.
>>>
>>> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>>> ---
>>> drivers/pci/probe.c | 12 ------------
>>> drivers/pci/setup-bus.c | 3 ---
>>> 2 files changed, 0 insertions(+), 15 deletions(-)
>>>
>>> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
>>> index d1181cd..362ec08 100644
>>> --- a/drivers/pci/probe.c
>>> +++ b/drivers/pci/probe.c
>>> @@ -288,10 +288,6 @@ static void __devinit pci_read_bridge_io(struct pci_bus *child)
>>> if (!res->end)
>>> res->end = limit + 0xfff;
>>> dev_printk(KERN_DEBUG, &dev->dev, " bridge window %pR\n", res);
>>> - } else {
>>> - dev_printk(KERN_DEBUG, &dev->dev,
>>> - " bridge window [io %#06lx-%#06lx] (disabled)\n",
>>> - base, limit);
>>> }
>>> }
>>>
>>> @@ -312,10 +308,6 @@ static void __devinit pci_read_bridge_mmio(struct pci_bus *child)
>>> res->start = base;
>>> res->end = limit + 0xfffff;
>>> dev_printk(KERN_DEBUG, &dev->dev, " bridge window %pR\n", res);
>>> - } else {
>>> - dev_printk(KERN_DEBUG, &dev->dev,
>>> - " bridge window [mem %#010lx-%#010lx] (disabled)\n",
>>> - base, limit + 0xfffff);
>>> }
>>> }
>>>
>>> @@ -363,10 +355,6 @@ static void __devinit pci_read_bridge_mmio_pref(struct pci_bus *child)
>>> res->start = base;
>>> res->end = limit + 0xfffff;
>>> dev_printk(KERN_DEBUG, &dev->dev, " bridge window %pR\n", res);
>>> - } else {
>>> - dev_printk(KERN_DEBUG, &dev->dev,
>>> - " bridge window [mem %#010lx-%#010lx pref] (disabled)\n",
>>> - base, limit + 0xfffff);
>>
>> No, We need to know what vaule BIOS write to those registers even they
>> are disabled.
>
> What do we learn from that?
printout the wrong value, so bios guy could fix them.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
