On Wed, Jun 23, 2021 at 05:01:02PM +0300, Andy Shevchenko wrote: > First of all, the "depends on" is no-op in the selectable options. > Second, no need to repeat menu dependencies (PCI). I believe you need to rewrite the commit log in a more descriptive way - as it is it is not very descriptive. Define which specific "depends on" you are referring to. I appreciate the intent and I believe the patch is sound. > Clean up the users of PCIE_DW_HOST and introduce idiom > > depends on PCI_MSI_IRQ_DOMAIN > select PCIE_DW_HOST > > for all of them. "All of them" ? We need something more explicit for this log to be useful, it took me a while to understand the end result you are achieving. Thanks, Lorenzo > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/pci/controller/dwc/Kconfig | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index 423d35872ce4..9bfd41eadd5e 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -8,7 +8,6 @@ config PCIE_DW > > config PCIE_DW_HOST > bool > - depends on PCI_MSI_IRQ_DOMAIN > select PCIE_DW > > config PCIE_DW_EP > @@ -22,8 +21,8 @@ config PCI_DRA7XX > config PCI_DRA7XX_HOST > bool "TI DRA7xx PCIe controller Host Mode" > depends on SOC_DRA7XX || COMPILE_TEST > - depends on PCI_MSI_IRQ_DOMAIN > depends on OF && HAS_IOMEM && TI_PIPE3 > + depends on PCI_MSI_IRQ_DOMAIN > select PCIE_DW_HOST > select PCI_DRA7XX > default y if SOC_DRA7XX > @@ -55,7 +54,7 @@ config PCIE_DW_PLAT > > config PCIE_DW_PLAT_HOST > bool "Platform bus based DesignWare PCIe Controller - Host mode" > - depends on PCI && PCI_MSI_IRQ_DOMAIN > + depends on PCI_MSI_IRQ_DOMAIN > select PCIE_DW_HOST > select PCIE_DW_PLAT > help > @@ -138,8 +137,8 @@ config PCI_LAYERSCAPE > bool "Freescale Layerscape PCIe controller - Host mode" > depends on OF && (ARM || ARCH_LAYERSCAPE || COMPILE_TEST) > depends on PCI_MSI_IRQ_DOMAIN > - select MFD_SYSCON > select PCIE_DW_HOST > + select MFD_SYSCON > help > Say Y here if you want to enable PCIe controller support on Layerscape > SoCs to work in Host mode. > @@ -244,8 +243,8 @@ config PCIE_HISI_STB > > config PCI_MESON > tristate "MESON PCIe controller" > - depends on PCI_MSI_IRQ_DOMAIN > default m if ARCH_MESON > + depends on PCI_MSI_IRQ_DOMAIN > select PCIE_DW_HOST > help > Say Y here if you want to enable PCI controller support on Amlogic > -- > 2.30.2 >
