On Fri, Jul 30, 2021 at 12:28 PM Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > > On Thu, Jul 29, 2021 at 04:49:10PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > > > PME signaling is only enabled by __pci_enable_wake() if the target > > device can signal PME from the given target power state (to avoid > > pointless reconfiguration of the device), but if the hierarchy above > > the device goes into D3cold, the device itself will end up in D3cold > > too, so if it can signal PME from D3cold, it should be enabled to > > do so in __pci_enable_wake(). > > > > [Note that if the device does not end up in D3cold and it cannot > > signal PME from the original target power state, it will not signal > > PME, so in that case the behavior does not change.] > > > > Link: https://lore.kernel.org/linux-pm/3149540.aeNJFYEL58@kreacher/ > > Fixes: 5bcc2fb4e815 ("PCI PM: Simplify PCI wake-up code") > > Reported-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > > Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > > Also this solves the reported issue so, > > Tested-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> Thank you! I'll queue up these two patches for 5.15 barring any objections from Bjorn.