> +int irq_affinity_calc_sets(unsigned int affvecs, struct irq_affinity *affd) > +{ > + /* > + * Simple invocations do not provide a calc_sets() callback. Call > + * the generic one. > + */ > + if (!affd->calc_sets) > + default_calc_sets(affd, affvecs); > + else > + affd->calc_sets(affd, affvecs); Nit: avoid pointless negations: if (affd->calc_sets) affd->calc_sets(affd, affvecs); else default_calc_sets(affd, affvecs); Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>