On 15.07.2021 23:59, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> Previously, when a VPD read failed, we warned about an "invalid large
> VPD tag". Warn about the VPD read failure instead.
>
LGTM. Seems no VPD has been broken enough yet to trigger this warning
(at that place), so there's not much need to argue.
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> ---
> drivers/pci/vpd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c
> index 26bf7c877de5..7bfb8fc4251b 100644
> --- a/drivers/pci/vpd.c
> +++ b/drivers/pci/vpd.c
> @@ -92,8 +92,8 @@ static size_t pci_vpd_size(struct pci_dev *dev, size_t old_size)
> (tag == PCI_VPD_LTIN_RW_DATA)) {
> if (pci_read_vpd(dev, off+1, 2,
> &header[1]) != 2) {
> - pci_warn(dev, "invalid large VPD tag %02x size at offset %zu",
> - tag, off + 1);
> + pci_warn(dev, "failed VPD read at offset %zu",
> + off + 1);
> return 0;
> }
> off += PCI_VPD_LRDT_TAG_SIZE +
>
