On 7/9/21 11:25 PM, Pali Rohár wrote: [...]
PCIe Function Level Reset should reset only one PCIe part of device. And seems that this type of reset does not work properly in some situations. Note that PCIe Function Level Reset is independent of running firmware. It is implement in hardware and (should) work also at early stage when firmware is not loaded yet. I'm starting to think more and more if quirk in this patch really needs to be behind DMI check and if rather it should not be called on other platforms too?
Maybe? I'm not sure how well this behaves on other devices and if there even are any devices outside of the MS Surface line that really require or benefit from something like this. To me it seems safer to put it behind quirks, at least until we know more. Also not sure if this is just my bias, but it feels like the Surface line always had more problems with that driver (and firmware) than others. I'm honestly a bit surprised that MS stuck with them for this long (they decided to go with Intel for 7th gen devices). AFAICT they initially chose Marvell due to connected standby support, so maybe that causes issue for us and others simply aren't using that feature? Just guessing though.
