Hi Lorenzo, On 08/07/21 2:53 pm, Uwe Kleine-König wrote: > On Mon, Jul 05, 2021 at 05:46:50PM +0200, Uwe Kleine-König wrote: >> Hello, >> >> On Tue, Jun 22, 2021 at 03:29:27PM +0530, Kishon Vijay Abraham I wrote: >>> On 23/02/21 2:37 pm, Uwe Kleine-König wrote: >>>> The driver core ignores the return value of pci_epf_device_remove() >>>> (because there is only little it can do when a device disappears) and >>>> there are no pci_epf_drivers with a remove callback. >>>> >>>> So make it impossible for future drivers to return an unused error code >>>> by changing the remove prototype to return void. >>>> >>>> The real motivation for this change is the quest to make struct >>>> bus_type::remove return void, too. >>>> >>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> >>> >>> Fine with this change! >>> >>> FWIW: >>> Acked-by: Kishon Vijay Abraham I <kishon@xxxxxx> >> >> Thanks for the ack. How can I expect this patch to go into mainline now? >> Will Bjorn pick it up now that you acked? > > There is a series[1] that I'd like to get into mainline during the next > merge window and that depends on this patch. Ideally it would go in > for v5.14-rc1, otherwise I'd like to add it to the series changing > bus_type::remove that it goes in together. Would be sad if I had to > delay this cleanup for this dependency not going in. Can you pick this change in the -rc cycle? Thank You, Kishon > > Best regards > Uwe > > [1] https://lore.kernel.org/lkml/20210706154803.1631813-1-u.kleine-koenig@xxxxxxxxxxxxxx > >
