Hi Krzysztof, On 04/07/21 2:31 am, Krzysztof Wilczyński wrote: > Hi Kishon, > >> Now that all PCI keystone functionality has been moved to pci-keystone.c, >> cleanup MSI/legacy interrupt configuration and handling. >> *) Cleanup macros >> *) Remove unnecessary structure variables (required when 2 files are >> used) >> *) Remove ks_dw_pcie_legacy_irq_chip and use dummy_irq_chip >> *) Move request_irq of error irq from ks_add_pcie_port to ks_pcie_probe >> as error_irq is common to both host mode and device mode > [...] > > While looking at some small clean-ups for Bjorn, I stumbled upon this > series, and it seems a lot of your work here cover what Bjorn wanted to > do, thus I need to ask - do you recall, and I appreciate it's been > a while (three years actually), what happened and/or if you ever had the > time to work on this series? > > Would it be possible to resurrect this? Do you need any help? A lot of patches in this series should already be merged (after splitting into smaller ones) http://patchwork.ozlabs.org/project/linux-pci/list/?series=71185 https://patchwork.kernel.org/project/linux-arm-kernel/cover/20190321095927.7058-1-kishon@xxxxxx/ The following series is still pending and is in my TODO list https://lore.kernel.org/r/20210325090026.8843-1-kishon@xxxxxx Are there any other clean-ups you are looking into? Thanks and Regards Kishon