On Fri, Jun 25, 2021 at 4:31 PM Krzysztof Wilczyński <kw@xxxxxxxxx> wrote: > > The struct bin_attribute requires the "mapping" member to be a function > pointer with a signature requiring the return type to be a pointer to > the struct address_space. > > Thus, convert every invocation of iomem_get_mapping() into a function > pointer assignment, therefore allowing for the iomem_get_mapping() > invocation to be deferred to when the sysfs open callback runs. > Looks good. Since I did not write any of the below go ahead and change the "Co-authored-by" to: Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx> Thanks for picking this up and carrying it through.