Hi Bjorn, On 6/5/21 3:53 PM, Bjorn Helgaas wrote: > This is a little sketchy. We shouldn't be doing device config stuff > after device_add() because that's when it becomes available for > drivers to bind to the device. If we do anything with the device > after that point, we may interfere with a driver. > > I think the problem is that we don't call acpi_bind_one() until > device_add(). There's some hackery in pci-acpi.c to deal with a > similar problem for something else -- see acpi_pci_bridge_d3(). Thanks for pointing to reference code. I've added a new patch for setting ACPI_COMPANION before device_add(). Please review the updated patch series v7 'Expose and manage PCI device reset' and provide feedback. -Shanker
