On Fri, May 13, 2011 at 10:04:15AM -0600, Alex Chiang wrote: > * Greg KH <greg@xxxxxxxxx>: > > On Fri, May 13, 2011 at 03:05:08AM -0600, Alex Chiang wrote: > > > * Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>: > > > > Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > > > > > > > > > > So remove rescan for all pci devices. less confusing > > > > > > > > I'm reluctant to break an existing interface like this, even though > > > > it's only in the "testing" section of the ABI. > > > > > > > > Alex, any comments? > > > > > > I think standard ABI deprecation practices should apply here. > > > > Ooh, I missed the fact that this series removed a sysfs file, you are > > right, we can't do that. > > > > So no, don't delete this file, please fix any tools that might happen to > > be using it, and then, in a year or so, we can revisit this to see if it > > makes sense to remove it. > > I thought we had some "best practices" to do that, like printing > out a big scary deprecation message when the file is accessed, > and documenting it in Documentation/ABI somewhere. Printing out such a message would be good, that would allow you to catch the tools that are doing it and change them. Documenting that the file is going away is for the Documentation/feature_removal.txt file, not the ABI files. So that all sounds like a good idea. Do you know what tools use this file? Any pointers to them would probably be appreciated. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
