> Date: Tue, 1 Jun 2021 15:33:14 -0500 > From: Rob Herring <robh@xxxxxxxxxx> > > On Tue, Jun 01, 2021 at 08:32:10AM -0500, Rob Herring wrote: > > On Mon, 31 May 2021 00:44:00 +0200, Mark Kettenis wrote: > > > From: Mark Kettenis <kettenis@xxxxxxxxxxx> > > > > > > The Apple PCIe host controller is a PCIe host controller with > > > multiple root ports present in Apple ARM SoC platforms, including > > > various iPhone and iPad devices and the "Apple Silicon" Macs. > > > > > > Signed-off-by: Mark Kettenis <kettenis@xxxxxxxxxxx> > > > --- > > > .../devicetree/bindings/pci/apple,pcie.yaml | 167 ++++++++++++++++++ > > > MAINTAINERS | 1 + > > > 2 files changed, 168 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/pci/apple,pcie.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/pci/apple,pcie.example.dts:20:18: fatal error: dt-bindings/pinctrl/apple.h: No such file or directory > > 20 | #include <dt-bindings/pinctrl/apple.h> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Looking at the example, I don't think you need this header. Indeed. And I forgot to remove it in the respin. > Looks like irq.h is needed though. Hmm, apple-aic.h includes irq.h, but the current t8103.dtsi includes both. Similar situation with arm-gic.h and irq.h, where some DT files include both and others only include arm-gic.h. I can do it either way for v3.
