On Tue, Jun 01, 2021 at 12:09:09PM -0500, Bjorn Helgaas wrote: > On Fri, May 28, 2021 at 02:12:08AM +0200, Pali Rohár wrote: > > On Tuesday 11 May 2021 18:16:12 Marek Behún wrote: > > > Ping? :) > > > > > > Marek > > > > Bjorn: Gentle reminder :) > > The current patch [1] doesn't look mergeable as-is. > > - "ASM1062 SATA controller causes an External Abort on controllers > which support Max Payload Size >= 512" doesn't sound like a > correct description. > > That description suggests the problem is with the *PCI > controller*, not with the ASM1062. I think that's incorrect; I > think the problem is with the ASM1062. > > I would expect something like "ASM1062 advertises Max_Payload_Size > Supported of 512, but in fact it cannot handle TLPs with payload > size of 512." MPS is somewhat complicated, and I don't think we have good documentation in the Linux source. FWIW, this paper has a really good explanation of the MPS (Max Payload Size) and MRRS (Max Read Request Size) concepts: https://www.xilinx.com/support/documentation/white_papers/wp350.pdf