Hi Evan, Thank you for sending updated version! [...] > V2: cosmetic fix for description part(suggested by Krzysztof) For future reference: as this is v2, then remember to update the subject link to [PATCH v2] so that everyone looking at incoming patches would be immediately made aware that this is a new version (also, some of our automation such as Patchwork uses this when parsing subject lines). Additionally, the changelog would customary be included under the "---" lines so that it would automatically be removed alongside commit related details from Git, see the following as an example: https://lore.kernel.org/linux-pci/20210601114301.2685875-1-linus.walleij@xxxxxxxxxx/ Having said that, I am not sure if this warrants sending v3, as this could be easily fixed here by either Bjorn or Lorenzo when this patch will be merged, if they don't mind, of course. [...] > @@ -5176,7 +5176,8 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0422, quirk_no_ext_tags); > static void quirk_amd_harvest_no_ats(struct pci_dev *pdev) > { > if ((pdev->device == 0x7312 && pdev->revision != 0x00) || > - (pdev->device == 0x7340 && pdev->revision != 0xc5)) > + (pdev->device == 0x7340 && pdev->revision != 0xc5) || > + (pdev->device == 0x7341 && pdev->revision != 0x00)) [...] > /* AMD Navi14 dGPU */ > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7340, quirk_amd_harvest_no_ats); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7341, quirk_amd_harvest_no_ats); [...] Thank you! Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx> Krzysztof
