[AMD Official Use Only]
Thanks Krzysztof. Comment inline
> -----Original Message-----
> From: Krzysztof Wilczyński <kw@xxxxxxxxx>
> Sent: Monday, May 31, 2021 10:41 PM
> To: Quan, Evan <Evan.Quan@xxxxxxx>
> Cc: linux-pci@xxxxxxxxxxxxxxx; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>
> Subject: Re: [PATCH] PCI: Mark AMD Navi14 GPU 0x7341 rev 0x00 ATS as
> broken
>
> Hi Evan,
>
> Thank you for sending the patch over!
>
> A small nitpick: the subject line could just say:
>
> Add quirk for AMD Navi 14 to disable ATS support
>
> Or something along these lines, as I am not sure how useful the ID and
> revision are in the subject, especially since the commit message explains in
> details what hardware is affected, etc.
>
[Quan, Evan] Will update it in V2.
> > Unexpected GPU hang was observed during runpm stress test on 0x7341
> > rev 0x00. Further debugging shows broken ATS is related. Thus as a
> > followup of commit 5e89cd303e3a ("PCI:
> > Mark AMD Navi14 GPU rev 0xc5 ATS as broken"), we disable the ATS for
> > the specific SKU also.
>
> As this might be a candidate for a back-port to current stable and long-term
> kernels, does it have any "Fixes" tag we could include here for reference? If
> not, then it's OK.
[Quan, Evan] We have an internal ticket/link for this. But that is not accessible outside AMD.
So, I would say there is no "Fixes" tag available for this.
>
> > Change-Id: I3d9d570bd473762e3bfbb251cf8abaf5af38ced9
>
> I assume this is from some code review service like Gerrit? We usually as
> people to drop these when sending patches to be included in the kernel (so
> when sending patches upstream).
>
> Krzysztof
[Quan, Evan] Thanks! Will drop it in V2.
BR
Evan
