Re: [PATCH -v2 1/3] pci: add rescan to /sys/.../pci_bus/.../

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 09, 2011 at 06:58:38PM -0700, Yinghai Lu wrote:
> --- linux-2.6.orig/drivers/pci/pci.h
> +++ linux-2.6/drivers/pci/pci.h
> @@ -160,8 +160,10 @@ extern struct device_attribute dev_attr_
>  extern struct device_attribute dev_attr_cpulistaffinity;
>  #ifdef CONFIG_HOTPLUG
>  extern struct bus_attribute pci_bus_attrs[];
> +extern struct device_attribute pcibus_attrs[];
>  #else
>  #define pci_bus_attrs	NULL
> +#define pcibus_attrs	NULL

That's a horrible name, it's not obvious what the difference is between
those two variables, right?

Please pick something different for the new one, "pcibus_dev_attrs"
perhaps?

Other than that, yes, that is the correct idea.  Please also move the
existing sysfs files for this device to your attribute list as well.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux