On Tue, May 18, 2021 at 1:41 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > PCI_IOSIZE is defined in mach-loongson64/spaces.h, so change the name > of the PCI_* macros in pci-ftpci100.c to use FTPCI_* so that they are > more localized and won't conflict with other drivers or arches. > > ../drivers/pci/controller/pci-ftpci100.c:37: warning: "PCI_IOSIZE" redefined > 37 | #define PCI_IOSIZE 0x00 > | > In file included from ../arch/mips/include/asm/addrspace.h:13, > ... from ../drivers/pci/controller/pci-ftpci100.c:15: > arch/mips/include/asm/mach-loongson64/spaces.h:11: note: this is the location of the previous definition > 11 | #define PCI_IOSIZE SZ_16M > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Suggested-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Krzysztof Wilczyński <kw@xxxxxxxxx> > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxxx > --- > v2: prefix PCI_ macro names with "FT", thus use FTPCI_ for these macro names. > (suggested by Linus Walleij) Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij