On Sun, May 16, 2021 at 9:00 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > PCI_IOSIZE is defined in mach-loongson64/spaces.h, so change the name > of this macro in pci-ftpci100.c. > > ../drivers/pci/controller/pci-ftpci100.c:37: warning: "PCI_IOSIZE" redefined > 37 | #define PCI_IOSIZE 0x00 > | > In file included from ../arch/mips/include/asm/addrspace.h:13, > ... from ../drivers/pci/controller/pci-ftpci100.c:15: > arch/mips/include/asm/mach-loongson64/spaces.h:11: note: this is the location of the previous definition > 11 | #define PCI_IOSIZE SZ_16M > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Cc: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxxx Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Though I suspect the real solution is to prefix all macros with FTPCI_*? Yours, Linus Walleij