On 2021-05-14 7:51 a.m., Christoph Hellwig wrote: >> +int __dma_map_sg_attrs(struct device *dev, struct scatterlist *sg, int nents, >> enum dma_data_direction dir, unsigned long attrs); > > I don't think it makes sense to expose this __dma_map_sg_attrs helper. > Just keep it static and move the sgtable helper to kernel/dma/mapping.c > as well. Makes sense. I'll fix this for v3. Logan