Hi Jianmin, [...] > In LS7A, multifunction device use same pci PIN and different > irq for different function, so fix it for standard pci PIN > usage. It would be "PCI" instead of "pci" and "IRQ" instead of "irq" in the commit message. This would also be true in the other patches in this series. [...] > + if (pci_match_id(devids, dev)) { > + u8 fun = dev->devfn & 7; You could use the PCI_FUNC() macro here. Krzysztof