Hi Tian, Thank you for sending the patch over! > request_irq() after setting IRQ_NOAUTOEN as below > irq_set_status_flags(irq, IRQ_NOAUTOEN); > request_irq(dev, irq...); > can be replaced by request_irq() with IRQF_NO_AUTOEN flag. A few comments. The commit message is a bit terse and the subject could be improved a little. Does this change fixes an issue with the driver? Why is this flag needed? The commit message could explain better why this change is needed, etc. Krzysztof