On Fri, Apr 16, 2021 at 03:20:10PM -0400, Stuart Hayes wrote: > This patch adds support for the PCIe SSD Status LED Management > interface, as described in the "_DSM Additions for PCIe SSD Status LED > Management" ECN to the PCI Firmware Specification revision 3.2. > > It will add a single (led_classdev) LED for any PCIe device that has the > relevant _DSM. The ten possible status states are exposed using > attributes current_states and supported_states. Reading current_states > (and supported_states) will show the definition and value of each bit: There is significant overlap in this ECN with the PCIe native enclosure management (NPEM) capability. Would it be possible for the sysfs interface to provide an abstraction such that both these implementations could subscribe to? > >cat /sys/class/leds/0000:88:00.0::pcie_ssd_status/supported_states > ok 0x0004 [ ] > locate 0x0008 [*] > fail 0x0010 [ ] > rebuild 0x0020 [ ] > pfa 0x0040 [ ] > hotspare 0x0080 [ ] > criticalarray 0x0100 [ ] > failedarray 0x0200 [ ] > invaliddevice 0x0400 [ ] > disabled 0x0800 [ ] > -- > supported_states = 0x0008 This is quite verbose for a sysfs property. The common trend for new properties is that they're consumed by programs as well as humans, so just ouputing a raw number should be sufficient if the values have a well defined meaning.
