[PATCH] PCI: Check value of resource alignment before using __ffs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Return value of __ffs is undefined if no set bit exists in
its argument. This indicates that the associated BAR has
invalid alignment.

Signed-off-by: Amey Narkhede <ameynarkhede03@xxxxxxxxx>
---
 drivers/pci/setup-bus.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 2ce636937c6e..44e8449418ae 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -1044,6 +1044,11 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask,
 			 * resources.
 			 */
 			align = pci_resource_alignment(dev, r);
+			if (!align) {
+				pci_warn(dev, "BAR %d: %pR has bogus alignment\n",
+					 i, r);
+				continue;
+			}
 			order = __ffs(align) - 20;
 			if (order < 0)
 				order = 0;
--
2.31.1



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux