Re: [PATCH v4 0/3] PCI: Disable parity checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30.03.2021 19:43, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> 
> I think this is essentially the same as Heiner's v3 posting, with these
> changes:
> 
>   - Added a pci_disable_parity() interface in pci.c instead of making a
>     public pci_quirk_broken_parity() because quirks.c is only compiled when
>     CONFIG_PCI_QUIRKS=y.
> 
>   - Removed the setting of dev->broken_parity_status because it's really
>     only used by EDAC error reporting, and if we disable parity error
>     reporting, we shouldn't get there.  This change will be visible in the
>     sysfs "broken_parity_status" file, but I doubt that's important.
> 
> I dropped Leon's reviewed-by because I fiddled with the code.  Similarly I
> haven't added your signed-off-by, Heiner, because I don't want you blamed
> for my errors.  But if this looks OK to you I'll add it.
> 
> v1: https://lore.kernel.org/r/a6f09e1b-4076-59d1-a4e3-05c5955bfff2@xxxxxxxxx
> v2: https://lore.kernel.org/r/bbc33d9b-af7c-8910-cdb3-fa3e3b2e3266@xxxxxxxxx
> - reduce scope of N2100 change to using the new PCI core quirk
> v3: https://lore.kernel.org/r/992c800e-2e12-16b0-4845-6311b295d932@xxxxxxxxx/
> - improve commit message of patch 2
> 
> v4:
> - add pci_disable_parity() (not conditional on CONFIG_PCI_QUIRKS)
> - remove setting of dev->broken_parity_status
> 
> 
> Bjorn Helgaas (1):
>   PCI: Add pci_disable_parity()
> 
> Heiner Kallweit (2):
>   IB/mthca: Disable parity reporting
>   ARM: iop32x: disable N2100 PCI parity reporting
> 
>  arch/arm/mach-iop32x/n2100.c              |  8 ++++----
>  drivers/net/ethernet/realtek/r8169_main.c | 14 --------------
>  drivers/pci/pci.c                         | 17 +++++++++++++++++
>  drivers/pci/quirks.c                      | 13 ++++---------
>  include/linux/pci.h                       |  1 +
>  5 files changed, 26 insertions(+), 27 deletions(-)
> 

LGTM. Thanks!



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux