On 3/29/21 9:10 AM, Lorenzo Pieralisi wrote: > On Fri, Mar 12, 2021 at 03:45:55PM -0500, Jim Quinlan wrote: >> The Broadcom STB PCIe RC uses a reset control "rescal" for certain chips. >> The "rescal" implements a "pulse reset" so using assert/deassert is wrong >> for this device. Instead, we use reset/rearm. We need to use rearm so >> that we can reset it after a suspend/resume cycle; w/o using "rearm", the >> "rescal" device will only ever fire once. >> >> Of course for suspend/resume to work we also need to put the reset/rearm >> calls in the suspend and resume routines. > > Actually - I am sorry but it looks like you will have to split the patch > in two since this is two logical changes. I do not believe this can be easily split, since there is currently a misused of the reset controller API and this patch fixes all call sites at once. It would not really make sense to fix probe/remove and then leave suspend/resume broken in the same manner. -- Florian
