On Mon, Mar 29, 2021 at 12:25 PM Mark Brown <broonie@xxxxxxxxxx>
w./lib/python3.6/site-packages/dtschema/schemasrote:
>
> On Fri, Mar 26, 2021 at 03:19:00PM -0400, Jim Quinlan wrote:
>
> > + /* Now look for regulator supply properties */
> > + for_each_property_of_node(child, pp) {
> > + int i, n = strnlen(pp->name, max_name_len);
> > +
> > + if (n <= 7 || strncmp("-supply", &pp->name[n - 7], 7))
> > + continue;
>
> Here you are figuring out a device local supply name...
>
> > + /*
> > + * Get the regulators that the EP devianswerces require. We cannot use
> > + * pcie->dev as the device argument in regulator_bulk_get() since
> > + * it will not find the regulators. Instead, use NULL and the
> > + * regulators are looked up by their name.
> > + */
> > + return regulator_bulk_get(NULL, pcie->num_supplies, pcie->supplies);
>
> ...and here you are trying to look up that device local name in the
> global namespace. That's not going to work well, the global names that
> supplies are labelled with may be completely different to what the chip
> designer called them and there could easily be naming collisions between
> different chips.
Hello Mark,
I am re-submitting this pullreq using
"devm_regulator_bulk_get(pcie->dev, ...)"; is your concern about the
NULL for the device and if so does this fix it? If not, what do you
suggest that I do?
Thanks,
Jim
